Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Docker container for riscv64 #836

Closed
wants to merge 3 commits into from
Closed

Use Docker container for riscv64 #836

wants to merge 3 commits into from

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Nov 5, 2023 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@luhenry
Copy link
Contributor Author

luhenry commented Nov 5, 2023

It depends on adoptium/infrastructure#3240

@luhenry luhenry mentioned this pull request Nov 8, 2023
Merged
6 tasks
@luhenry
Use cross-compilation with Docker for riscv64
9d54010 
The boards are just too limited at the moment.

It only targets jdk17u, jdk19u, and jdk20u for now for lack of Ubuntu
20.04 compatible builds of jdk20u (for jdk21u) and jdk21u (for jdk22).
Once we've some builds of jdk20u on Ubuntu 20.04, we can enable
jdk21u. Next we can do jdk21u for jdk22.
@luhenry luhenry force-pushed the riscv64-docker-images branch from 02b867a to 9d54010 Compare November 9, 2023 17:12
@luhenry luhenry marked this pull request as ready for review November 9, 2023 17:48
@luhenry
Copy link
Contributor Author

luhenry commented Nov 10, 2023

It is currently blocked by not being able to push the adoptopenjdk/ubuntu2004_build_image:linux-riscv64 to hub.docker.com. See https://ci.adoptium.net/job/centos7_docker_image_updater/397/console for details

@sxa
Copy link
Member

sxa commented Nov 17, 2023 •
edited
Loading

This isn't cross compilation so those options aren't likely to work - this PR is trying to run in an emulated environment so from the build process perspective it would be running "natively". Actually that option in the pipelines isn't named very well so what you've got it probably ok and consistent with what we do for arm32 on aarch64 (Although those do execute natively on the hardware)

But as you say it isn't going to work yet until we can push it up.

Why did you select x64 as the host specifically for this?

@luhenry
Copy link
Contributor Author

luhenry commented Nov 17, 2023 •
edited
Loading

But as you say it isn't going to work yet until we can push it up.

Is there a way to manually push the image until the CI is fixed? Given RISC-V isn't an officially supported platform, the necessity for tracking sources of the tools isn't as much a requirement?

Why did you select x64 as the host specifically for this?

Kinda of by default. Happy to use something else if it's any better. The other ones I would see is aarch64 if we have enough machines in that pool (and fast enough) to dedicate to that.

sxa
sxa reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the commit message on this - I know the option in the pipelines says "crossCompile" but since this is not using a cross-compiler (it's still running the native riscv64 compiler) I'd prefer it to say "Use system emulation" or something along those lines.

@luhenry luhenry changed the title Use cross-compilation with Docker for riscv64 Use Docker container for riscv64 Dec 14, 2023
@luhenry
Copy link
Contributor Author

luhenry commented Dec 14, 2023

Scaling down the scope of this PR to only using the docker container. We'll see to use x64 host on a follow-up PR.

@luhenry luhenry mentioned this pull request Dec 20, 2023
Open
7 tasks
@luhenry
Copy link
Contributor Author

luhenry commented Dec 21, 2023

Superseded by #864

@luhenry luhenry closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa left review comments

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
cross-compile jenkins-pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhenry @sxa @karianna