Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jdk17 reproducible comparison builds #840

Closed
wants to merge 1 commit into from

Conversation

sophia-guo
Copy link
Contributor

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Copy link

github-actions bot commented Nov 8, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo sophia-guo requested a review from sxa November 8, 2023 20:04
@sophia-guo sophia-guo self-assigned this Nov 8, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no description or issue reference on this PR - why are we disabling it?

@andrew-m-leonard
Copy link
Contributor

I realise the jdk17u compares have been red for a while, and we need to have a look at them, but is there another reason to remove them?

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Nov 13, 2023

@jiekang mentioned it's not needed anymore for 17 and we only need to focus on 21. Not in a hurry we can wait until he's back and double check.

@sxa
Copy link
Member

sxa commented Nov 14, 2023

Given the amount of work we've put into backporting stuff into the 17 codebase I'm personally very much -1 on this unless we are actively choose to avoid maintaining it.

@sophia-guo
Copy link
Contributor Author

Based on the discussion we will hold it off for now

@sophia-guo sophia-guo closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants