Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update macOS labels to pin XCode version #843

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Nov 17, 2023

Switches the pinning from OS version to XCode version

Also sets up the labels to work with Orka

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting here that the jdk11u pipeline is not having a tag applied as it uses the default command line compiler installed by brew, which is a little worrying (Related: adoptium/infrastructure#3249 (comment))

Also not sure what impact this might have on the corretto builds since we're removing the label, but we don't seem to have built that for close to four years now so 🤷🏻 : https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-corretto/

Also noting that this part of the orka3 migration work in adoptium/infrastructure#2536

@gdams gdams merged commit 76ba6c0 into adoptium:master Nov 17, 2023
7 checks passed
@gdams gdams deleted the mac branch November 17, 2023 14:05
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants