Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default activeNodeTimeout from 0 to 1 min #853

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

smlambert
Copy link
Contributor

Addresses the 30 second lag for spinning up Orka machines, but also seems to be a more sensible default timeout setting than zero minutes (especially since it doesn't delay sending jobs to machines if they are available in zero minutes).

Related: adoptium/aqa-tests#4899

Signed-off-by: Shelley Lambert <slambert@gmail.com>
Copy link

github-actions bot commented Dec 6, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo
Copy link
Contributor

Might also need to update https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/jobs/pipeline_job_template.groovy#L94

Signed-off-by: Shelley Lambert <slambert@gmail.com>
@smlambert smlambert marked this pull request as ready for review December 6, 2023 23:55
Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smlambert smlambert merged commit 833a06d into adoptium:master Dec 7, 2023
6 of 7 checks passed
zijwij-byxmyq-1wIxre

This comment was marked as spam.

luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
* Change default activeNodeTimeout from 0 to 1 min

Signed-off-by: Shelley Lambert <slambert@gmail.com>

* Update template

Signed-off-by: Shelley Lambert <slambert@gmail.com>

---------

Signed-off-by: Shelley Lambert <slambert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants