-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use actions/labeler@v5
config file format
#860
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
actions/labeler@v5
config file format
Signed-off-by lemeurherve.jenkins@gmail.com
I signed-off my commit with the mail I've used to create my Eclipse account and sign the ECA, I don't know what to do more. |
@lemeurherve I revalidated the signing process so that passes now. Reading the labeler documentation tells me your change is likely correct but it's hard to tell since pull_request_target only runs against the base branch (https://github.com/actions/labeler?tab=readme-ov-file#notes-regarding-pull_request_target-event) it still 'fails'. I'll merge this as it's a step in the right direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a step in the right direction
Needs one more approval |
Signed-off-by lemeurherve.jenkins@gmail.com
This PR adapts the labeler config file to the new format introduced in version 5.
Related to: