Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use actions/labeler@v5 config file format #860

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

lemeurherve
Copy link
Contributor

This PR adapts the labeler config file to the new format introduced in version 5.

Related to:

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@lemeurherve lemeurherve changed the title fix: use action/labeler@5 config file format fix: use actions/labeler@v5 config file format Dec 15, 2023
Signed-off-by lemeurherve.jenkins@gmail.com
@lemeurherve
Copy link
Contributor Author

I signed-off my commit with the mail I've used to create my Eclipse account and sign the ECA, I don't know what to do more.

@karianna
Copy link
Contributor

karianna commented Jan 1, 2024

@lemeurherve I revalidated the signing process so that passes now. Reading the labeler documentation tells me your change is likely correct but it's hard to tell since pull_request_target only runs against the base branch (https://github.com/actions/labeler?tab=readme-ov-file#notes-regarding-pull_request_target-event) it still 'fails'. I'll merge this as it's a step in the right direction.

@karianna karianna enabled auto-merge (squash) January 1, 2024 23:48
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction

@karianna
Copy link
Contributor

karianna commented Jan 1, 2024

Needs one more approval

@karianna karianna merged commit 338b086 into adoptium:master Jan 2, 2024
5 of 7 checks passed
@lemeurherve lemeurherve deleted the patch-1 branch January 12, 2024 00:53
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Signed-off-by lemeurherve.jenkins@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants