-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable docker image for RISC-V on 21, 22, 23 #869
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
Using this configuration works on jdk21u as verified with https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk21u/job/jdk21u-evaluation-linux-riscv64-temurin/92/. It's also verifying on jdk22 with https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk22/job/jdk22-evaluation-linux-riscv64-temurin/11. |
@smlambert @sxa @andrew-m-leonard could I please get a review? This is to match what's done for jdk17u, and jdk19u. I've verified it works for jdk22 at https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk22/job/jdk22-evaluation-linux-riscv64-temurin/11/ |
Note sure if related but groovy tests fail: Execution failed for task ':test'.
|
re: #869 (comment) - seen prior to this PR, reported in #866 |
@sxa @smlambert does that look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For reference here are the likely last pipelines for 21 and 22 before this change:
I've triggered a regen of the pipeline jobs so they should pick up this new parameter for the next runs |
We verified it works on jdk21u with https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk21u/job/jdk21u-evaluation-linux-riscv64-temurin/92
Relates to adoptium/temurin-build#3591