Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Fix: Add checksum verification of dynamic asm downloads #877

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #876

Include MD5 checksum verification of ASM downloads.

Copy link

github-actions bot commented Jan 8, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

tools/code-tools/jcov.sh Outdated Show resolved Hide resolved
@steelhead31 steelhead31 requested a review from karianna January 9, 2024 08:36
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplicity suggestion
Also suggest adding Ref: TOB-TEMURIN-xx in the description as a reference for these fixes :-)

Noting that downloading and using an MD5 checksum file from the same place as the tarball is not ideal, but since the version can be dynamically obtained from a build.properties file we can't hard code it along with the version number (unless we add that to build.properties)

I'm ok to approve this as-is so we have some sort of check, but we should create an issue to come up with a better solution for the future.

tools/code-tools/jcov.sh Show resolved Hide resolved
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but as per earlier comment let's get another issue created to look at doing this in a better way in the future - and to look for other similar instances

@steelhead31 steelhead31 changed the title Security Fix: Add checksum verification of dynamic asm downloads Security Fix: Add checksum verification of dynamic asm downloads (TOB-TEMURIN-12) Jan 9, 2024
@steelhead31 steelhead31 changed the title Security Fix: Add checksum verification of dynamic asm downloads (TOB-TEMURIN-12) Security Fix: Add checksum verification of dynamic asm downloads Jan 9, 2024
@Haroon-Khel
Copy link
Contributor

ping @karianna for rereview

@Haroon-Khel Haroon-Khel enabled auto-merge (squash) January 9, 2024 17:54
@Haroon-Khel Haroon-Khel merged commit 706dcea into adoptium:master Jan 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JCOV Tools Download Without Integrity Checks
4 participants