Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Signverify Job - Change WindowsKitPath to find latest signtool rather than earliest/first #962

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #917

Amend the search for signtool.exe to perform a reverse sort on the search for signtool.exe.

On arm64 in particular, the earliest version ( 17763 ) does not actually work, which I believe is a bug in the earlier SDKS, and the later versions work correctly.

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@steelhead31
Copy link
Contributor Author

run tests quick 21

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steelhead31 steelhead31 requested a review from sophia-guo March 11, 2024 12:34
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@steelhead31 steelhead31 merged commit 120f119 into adoptium:master Mar 11, 2024
11 of 13 checks passed
@steelhead31 steelhead31 deleted the fix_win_arm_signverify branch March 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows aarch64 sign_verification not running signtool.exe correctly
4 participants