Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPB: Include Pre-Req Packages For SSL Test #3169

Merged
merged 13 commits into from
Oct 12, 2023

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Aug 29, 2023

Fixes #3059

Install packages required for running ssl-tests for 3rd party clients ( gnutls / nss / openssl ), also include appropriate documentation update, and an additional test has been added to the VPC tests.

Checklist
  • commit message has one of the standard prefixes
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)

@steelhead31
Copy link
Contributor Author

@steelhead31 steelhead31 marked this pull request as ready for review August 29, 2023 15:46
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things (OK it's three!)

  1. I presume this doesn't modify any existing openssl install or links etc that might affect anything building against it (e.g. openh9)
  2. Are we happy that this will be ok on CentOS6?
  3. This will presumably need to be added to the Dockerfiles in the DockerStatic role since those are used for most of our test machines

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as this will need to be in the docker files

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

FAQ.md Show resolved Hide resolved
@sxa
Copy link
Member

sxa commented Sep 27, 2023

/thaw

@github-actions github-actions bot dismissed their stale review September 27, 2023 10:04

Pull Request unblocked - code freeze is over.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the Alpine dockerfiles have had the new packages added to the existing apk line but for the other distributions they use a separate apt/yum command? Would be nice to be consistent across the distributions for maintenance purposes.

@steelhead31 steelhead31 requested a review from sxa September 28, 2023 13:54
@steelhead31
Copy link
Contributor Author

Ubuntu 21.04 check failure due to "hirsute" repos being removed.

@steelhead31
Copy link
Contributor Author

Is there a reason why the Alpine dockerfiles have had the new packages added to the existing apk line but for the other distributions they use a separate apt/yum command? Would be nice to be consistent across the distributions for maintenance purposes.

Nope, I'll align them, I think I had the idea to seperate them for clarities sake, probably after I'd done the alpine ones, they should be aligned now.

@steelhead31
Copy link
Contributor Author

@sxa I've also run the openj9 crypto tests ( in fact the whole java_security suite ) with a build of openj9 (jdk17), and thats all worked fine in both and Ubuntu/x64 vagrant & VM environments.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@steelhead31 steelhead31 merged commit fcb6021 into adoptium:master Oct 12, 2023
15 of 21 checks passed
@steelhead31 steelhead31 deleted the fix_issue_3059 branch October 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies for ssl-tests testsuite
3 participants