-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Include Pre-Req Packages For SSL Test #3169
Conversation
Include pre-requisite packages for running SSL client tests.
VPC run with SSL tests on Fed35.. https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Fedora35,label=vagrant/1703/console VPC Assorted other platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things (OK it's three!)
- I presume this doesn't modify any existing openssl install or links etc that might affect anything building against it (e.g. openh9)
- Are we happy that this will be ok on CentOS6?
- This will presumably need to be added to the Dockerfiles in the DockerStatic role since those are used for most of our test machines
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/vars/openSUSE.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/Debian.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes as this will need to be in the docker files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
/thaw |
Pull Request unblocked - code freeze is over.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/vars/Alpine.yml
Outdated
Show resolved
Hide resolved
…/Alpine.yml Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the Alpine dockerfiles have had the new packages added to the existing apk
line but for the other distributions they use a separate apt/yum command? Would be nice to be consistent across the distributions for maintenance purposes.
Ubuntu 21.04 check failure due to "hirsute" repos being removed. |
Nope, I'll align them, I think I had the idea to seperate them for clarities sake, probably after I'd done the alpine ones, they should be aligned now. |
@sxa I've also run the openj9 crypto tests ( in fact the whole java_security suite ) with a build of openj9 (jdk17), and thats all worked fine in both and Ubuntu/x64 vagrant & VM environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
Fixes #3059
Install packages required for running ssl-tests for 3rd party clients ( gnutls / nss / openssl ), also include appropriate documentation update, and an additional test has been added to the VPC tests.
Checklist