-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download cross-build jdk17u and jdk21u from CI #3308
Conversation
We don't want to rely on openjdk-17-jdk from Ubuntu 20.04 repositories, it crashes when running on VF2.
25657a1
to
a02157b
Compare
block: | ||
- name: Download jdk{{ jdk_version }} release (Linux-riscv64) | ||
get_url: | ||
url: https://api.adoptium.net/v3/binary/version/jdk-21.0.1+12.1-ea-beta/linux/riscv64/jdk/hotspot/normal/adoptium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a checksum into this to verify the download since it's a special case.
For the 21.0.1+12 that means:
checksum: sha256:c9b8b1ca18b13e293688cafbd8990c940ca49104dbeefc242e5c3f8de271abdf
and for the 17 download:
checksum: sha256:c9b8b1ca18b13e293688cafbd8990c940ca49104dbeefc242e5c3f8de271abdf
These should work in these stanzas in the same as the example at
infrastructure/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Ant-Contrib/tasks/main.yml
Line 34 in 7042913
checksum: sha256:c9b8b1ca18b13e293688cafbd8990c940ca49104dbeefc242e5c3f8de271abdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checksums you've given me here are duplicate. I assume due to a bad c/p. I've added the checksums I get when downloading them locally.
bc7094c
to
8344f2c
Compare
I can successfully generate a new image locally, and I get the following versions for jdk17u and 21u:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Haroon-Khel ! |
We don't want to rely on openjdk-17-jdk from Ubuntu 20.04 repositories, it crashes when running on VF2.
Relates to adoptium/temurin-build#3591
Checklist