Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download cross-build jdk17u and jdk21u from CI #3308

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Dec 21, 2023

We don't want to rely on openjdk-17-jdk from Ubuntu 20.04 repositories, it crashes when running on VF2.

Relates to adoptium/temurin-build#3591

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

We don't want to rely on openjdk-17-jdk from Ubuntu 20.04 repositories,
it crashes when running on VF2.
block:
- name: Download jdk{{ jdk_version }} release (Linux-riscv64)
get_url:
url: https://api.adoptium.net/v3/binary/version/jdk-21.0.1+12.1-ea-beta/linux/riscv64/jdk/hotspot/normal/adoptium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a checksum into this to verify the download since it's a special case.
For the 21.0.1+12 that means:

    checksum: sha256:c9b8b1ca18b13e293688cafbd8990c940ca49104dbeefc242e5c3f8de271abdf

and for the 17 download:

    checksum: sha256:c9b8b1ca18b13e293688cafbd8990c940ca49104dbeefc242e5c3f8de271abdf

These should work in these stanzas in the same as the example at

checksum: sha256:c9b8b1ca18b13e293688cafbd8990c940ca49104dbeefc242e5c3f8de271abdf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checksums you've given me here are duplicate. I assume due to a bad c/p. I've added the checksums I get when downloading them locally.

@luhenry
Copy link
Contributor Author

luhenry commented Dec 21, 2023

I can successfully generate a new image locally, and I get the following versions for jdk17u and 21u:

$> /usr/lib/jvm/jdk-17/bin/java -version
openjdk version "17.0.9-beta" 2023-10-17
OpenJDK Runtime Environment Temurin-17.0.9+9-202312211718 (build 17.0.9-beta+9-202312211718)
OpenJDK 64-Bit Server VM Temurin-17.0.9+9-202312211718 (build 17.0.9-beta+9-202312211718, mixed mode)
$> /usr/lib/jvm/jdk-21/bin/java -version
openjdk version "21.0.1-beta" 2023-10-17
OpenJDK Runtime Environment Temurin-21.0.1+12.1-202311211047 (build 21.0.1-beta+12-202311211047)
OpenJDK 64-Bit Server VM Temurin-21.0.1+12.1-202311211047 (build 21.0.1-beta+12-202311211047, mixed mode, sharing)

Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member

sxa commented Dec 22, 2023

Thanks @Haroon-Khel !

@sxa sxa merged commit 9d560a4 into adoptium:master Dec 22, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants