-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installers: Add Base Installer Files Ahead Of JDK21 release. #735
Conversation
Checks fail, as the binary files are not present yet. |
linux/jdk/suse/src/main/packaging/temurin/21/temurin-21-jdk.spec
Outdated
Show resolved
Hide resolved
linux/jdk/suse/src/main/packaging/temurin/21/temurin-21-jdk.spec
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points to consider. Once addressed (fixed/justified), will approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
linux/jdk/redhat/src/main/packaging/temurin/21/temurin-21-jdk.spec
Outdated
Show resolved
Hide resolved
DO NOT MERGE UNTIL CHECKSUMS ARE CORRECTED FOR RELEASE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
linux/jdk/redhat/src/main/packaging/temurin/21/temurin-21-jdk.spec
Outdated
Show resolved
Hide resolved
/thaw |
Pull Request unblocked - code freeze is over.
561446d
to
6b65786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specs look fine to me. Would be nice if the GH check could test them. Wonder if it's worthwhile in making the specs usable when not all arches are available... but for a separate conversation
Co-authored-by: George Adams <george.adams@microsoft.com>
Co-authored-by: George Adams <george.adams@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (subject to ppc64le either being removed or waiting until it's been shipped)
DO NOT MERGE UNTIL CHECKSUMS ARE CORRECT
Add the initial base files which will require the usual filename, checksum and version number updates during the release.
Fixes #736