Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installers: Add Base Installer Files Ahead Of JDK21 release. #735

Merged
merged 23 commits into from
Oct 13, 2023

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Sep 18, 2023

DO NOT MERGE UNTIL CHECKSUMS ARE CORRECT

Add the initial base files which will require the usual filename, checksum and version number updates during the release.

Fixes #736

@steelhead31
Copy link
Contributor Author

Checks fail, as the binary files are not present yet.

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points to consider. Once addressed (fixed/justified), will approve.

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

linux/Jenkinsfile Outdated Show resolved Hide resolved
linux/jdk/alpine/src/main/packaging/temurin/21/APKBUILD Outdated Show resolved Hide resolved
linux/jre/alpine/src/main/packaging/temurin/21/APKBUILD Outdated Show resolved Hide resolved
@steelhead31 steelhead31 requested a review from gdams September 19, 2023 08:30
@steelhead31
Copy link
Contributor Author

DO NOT MERGE UNTIL CHECKSUMS ARE CORRECTED FOR RELEASE

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@gdams
Copy link
Member

gdams commented Oct 11, 2023

/thaw

@github-actions github-actions bot dismissed their stale review October 11, 2023 19:27

Pull Request unblocked - code freeze is over.

@gdams gdams force-pushed the add_jdk_21 branch 2 times, most recently from 561446d to 6b65786 Compare October 11, 2023 19:40
Copy link
Contributor

@jiekang jiekang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs look fine to me. Would be nice if the GH check could test them. Wonder if it's worthwhile in making the specs usable when not all arches are available... but for a separate conversation

Co-authored-by: George Adams <george.adams@microsoft.com>
@steelhead31 steelhead31 requested a review from gdams October 12, 2023 18:02
Co-authored-by: George Adams <george.adams@microsoft.com>
@steelhead31 steelhead31 requested a review from gdams October 12, 2023 20:04
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (subject to ppc64le either being removed or waiting until it's been shipped)

@steelhead31 steelhead31 merged commit 69794eb into adoptium:master Oct 13, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add installer files for JDK21
5 participants