Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to run sanity and extended.functional testing to nightly builds of Aarch64 #2085

Closed
pshipton opened this issue Sep 16, 2020 · 10 comments
Labels
enhancement Issues that enhance the code or documentation of the repo in any way testing Issues that enhance or fix our test suites
Milestone

Comments

@pshipton
Copy link
Contributor

The OpenJ9 project doesn't have enough Aarch64 machines to provide test coverage for this platform. Adopt is running a number of test suites on this platform already, but not the sanity.functional and extended.functional suites. This is a request to add these test buckets to the nightly builds.

@pshipton pshipton changed the title Request to run sanity and extended.funtional testing to nightly builds of Aarch64 Request to run sanity and extended.functional testing to nightly builds of Aarch64 Sep 16, 2020
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Sep 17, 2020
@llxia
Copy link
Contributor

llxia commented Sep 17, 2020

@LongyuZhang could you help with this issue? Thanks.
This can be done after PR #2024 is merged.

@smlambert
Copy link
Contributor

smlambert commented Sep 17, 2020

Yes, I have generated these test jobs and run them in the past, but not included yet to be launched as part of the nightly test targets. It will be definitely better to launch them from here (instead of via Jenkins cron) as then we will be able to see the results in TRSS, since it is monitoring these build pipelines.

Note, we may need to re-autogen the test jobs, as there have been updates to the param list since they were first created.

@llxia
Copy link
Contributor

llxia commented Sep 24, 2020

@pshipton @smlambert should we enable aarch64 functional testing for JDK8 and JDK11? Do we want to enable for JDK16? We have 8 aarch64 testing machines at Adopt. Since we run other tests on aarch64 as well, maybe we should enable functional testing on one or two JDK versions and adjust this as needed.

@pshipton
Copy link
Contributor Author

I understand the aarch64 resource is concentrating on jdk11 followed by jdk8. I don't think much effort has been made to fix jdk15 issues, and in the end we didn't include aarch64 in the last jdk15 release. jdk16 is WIP and could have issues unrelated to aarch64 at this point. I'd start with jdk11, add jdk8 if machine resources allow, and we can look at adding jdk15 or jdk16 later.

@knn-k fyi.

LongyuZhang added a commit to LongyuZhang/temurin-build that referenced this issue Sep 25, 2020
- enable sanity and extended.functional testing to Aarch64 nightly builds
- Issue:adoptium#2085

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
smlambert pushed a commit that referenced this issue Sep 28, 2020
…ds (#2105)

- enable sanity and extended.functional testing to Aarch64 nightly builds
- Issue:#2085

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@pshipton
Copy link
Contributor Author

pshipton commented Oct 7, 2020

Noticed that in the 0.23.0 M2 build there is a mismatch between test material and build. It's running the head stream tests against the 0.23.0 release content.

https://trss.adoptopenjdk.net/resultSummary?parentId=5f7b58b111d26031c1db12b7

@llxia
Copy link
Contributor

llxia commented Oct 7, 2020

This is not specific to aarch64. This is a general issue. It shows up in aarch64 because we enabled functional tests on aarch64.

The default OPENJ9_BRANCH is set to master unless it is overridden by the upstream build script. In this case, it should be set to v0.23.0-release.

I manually trigger the test build with v0.23.0-release branch. However, the upstream SDK does not exist anymore
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.functional_aarch64_linux/11/

To fix this, the upstream build script should allow the user to set OPENJ9_BRANCH. Similar to RELEASE_TAG

@smlambert
Copy link
Contributor

I believe this can be closed since #2105 was merged and #2166 to address the version skew.

@pshipton
Copy link
Contributor Author

pshipton commented Nov 3, 2020

@smlambert I believe the functionality tests are only running for jdk11. If there is machine capacity, should I open another issue to run them for jdk8?

@karianna karianna added this to the November 2020 milestone Nov 3, 2020
@smlambert
Copy link
Contributor

Re-open to add for jdk8

@smlambert smlambert reopened this Nov 3, 2020
LongyuZhang added a commit to LongyuZhang/temurin-build that referenced this issue Nov 3, 2020
- enable sanity and extended.functional testing to Aarch64 jdk8 nightly builds
- Issue:adoptium#2085

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@karianna karianna modified the milestones: November 2020, December 2020 Jan 3, 2021
@M-Davies M-Davies added the testing Issues that enhance or fix our test suites label Feb 1, 2021
@M-Davies
Copy link

M-Davies commented Feb 1, 2021

JDK/aarch64/J9 sanity.functional testing and JDK/aarch64/J9 extended.functional testing are both enabled in the nightly pipelines. Closing...

@M-Davies M-Davies closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way testing Issues that enhance or fix our test suites
Projects
None yet
Development

No branches or pull requests

5 participants