Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually delete problimatic file on windows #1892

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

M-Davies
Copy link

  • Also disables DeferredWipeout on hotspot builds because why not

Closes: #1855
Signed-off-by: Morgan Davies morgan.davies@ibm.com

* Also disables DeferredWipeout on hotspot builds because why not

Signed-off-by: Morgan Davies <morgan.davies@ibm.com>
@M-Davies M-Davies added bug Issues that are problems in the code as reported by the community windows Issues that affect or relate to the WINDOWS OS labels Jun 16, 2020
@M-Davies M-Davies requested a review from sxa June 16, 2020 11:02
@M-Davies
Copy link
Author

Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- Though I would suppose it can only really be tested on a machine that we know is having that specific issue - or indeed if we stop having those issues at all. Cheers for this

@M-Davies
Copy link
Author

If you look at the past builds, one of them showed that issue with the next build after that using this code fixed it

@Willsparker
Copy link
Contributor

Ah okay- I wonder why #3 didn't work?

@karianna karianna added this to the June 2020 milestone Jun 16, 2020
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try it and see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows intermittently unable to clear _the.. file after OpenJ9 build
3 participants