Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Xcode 11.7 for building the JDK #2197

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Select Xcode 11.7 for building the JDK #2197

merged 1 commit into from
Oct 31, 2020

Conversation

aahlenst
Copy link
Contributor

GitHub switched to 12 on Oct 20:
actions/runner-images#1712

Should fix build problems that manifest as

configure: error: Xcode 4, 9, 10 or 11 is required to build JDK 8, the version found was 12.0.1. Use --with-xcode-path to specify the location of Xcode or make Xcode active by using xcode-select. configure exiting with result code 1 Makefile:55: *** Cannot continue. Stop.

@smlambert smlambert mentioned this pull request Oct 30, 2020
Merged
@M-Davies M-Davies added bug Issues that are problems in the code as reported by the community code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts macos Issues that affect or relate to the MAC OS labels Oct 30, 2020
@aahlenst aahlenst mentioned this pull request Oct 30, 2020
Closed
@aahlenst aahlenst marked this pull request as ready for review October 31, 2020 12:30
@aahlenst
Explicitly configure Xcode to use in GH Actions
f362cd0 
This prevents surprising build breaks caused by changing defaults.
xcode-select and the setup-xcode-version Action have no effect on
OpenJDK's configure.

Triggered by GitHub changing the default Xcode to 12 on Oct 20:
actions/runner-images#1712
smlambert
smlambert approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aahlenst !

@smlambert smlambert merged commit 5080caa into adoptium:master Oct 31, 2020
@karianna karianna added this to the October 2020 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
bug Issues that are problems in the code as reported by the community code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts macos Issues that affect or relate to the MAC OS
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@aahlenst @smlambert @gdams @karianna @M-Davies