Stop showing full SBoM output in build log #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
jenkins
Signed-off-by: Stewart X Addison <sxa@redhat.com>
sxa
force-pushed
the
stop_printing_sbom
branch
from
2637d75 to
feca1be
Compare
github-actions
bot
added
jenkins
karianna
approved these changes
Dec 11, 2023
Yeah this is the TKG issue that's been affecting multiple PRs (Raised in Slack and I'll get an issue raised today if no-one picks it up) . I'm not really sure why we're running TKG stuff as part of the build tests (I've queried that in this slack thread) |
andrew-m-leonard
approved these changes
Dec 19, 2023
Ah good to know - not so controversial after all then ;-) |
|
Re-running build checks now that adoptium/aqa-tests#4914 has been resolved. |
|
Checks are still failing, but they're failing on other PRs such as #3590 so I'm merging anyway. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussions starter: I personally find that the display of the SBoM content is overly verbose, and it typically makes it harder to find what I want in the log because I have to start at the bottom and scroll back to the "good bits". This PR suggests changing it so that it prints the location on the file system instead of printing it out. While this may be useful for debug/development I don't think it should print it by default. Bear in mind this content will also be archived afterwards along with the build itself.
In addition we print the metadata out in the pipelines job at https://github.com/adoptium/ci-jenkins-pipelines/blob/833a06de53ae21ffec043863600a88a5dbbb6529/pipelines/build/common/openjdk_build_pipeline.groovy#L1275 which should probably be removed too, but I'm looking for feedback before creating a second PR for that.