forked from facebook/react
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hasSelectionCapabilities: email, tel and url input-fields can have se…
…lections too (fixes problem when input field changes type on dynamically)
- Loading branch information
1 parent
4ca7855
commit db923b8
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit db923b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or what about
typeof elem.selectionStart === 'number'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, once I get on to implement a proper fix, I will take your suggestions into account.
Hi @adrianimboden, I'm thinking that you can improve using this code.
What do you think?