Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brighton Ruby 2023 videos #167

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

marcoroth
Copy link
Collaborator

@marcoroth marcoroth commented Aug 26, 2024

This PR is based on #266.

Organisation Show Event Show
CleanShot 2024-10-30 at 23 40 07 CleanShot 2024-10-30 at 23 38 55

@marcoroth marcoroth force-pushed the brighton-ruby-2023 branch 2 times, most recently from e704f95 to fa61fb7 Compare August 27, 2024 00:47
@adrienpoly
Copy link
Owner

Thanks for this great addition.

I think we should ask @andycroll permission first. Organizers who are publishing their videos on Youbute defacto accept that their video can be embedded into another website as it is a native feature of Youtube. Also videos viewed from embedded players do count for the view stats on Youtube.

For orgs having made the choice to host by themself the videos, I think we should get their explicit consent first.

One option could be that we just pull the metadata + Thumbnail and link to the Org website for the player (to be decided by the org)

@marcoroth
Copy link
Collaborator Author

Good point, I'm more than happy to extract the video provider to its own pull request, since it's technically two "features" in one pull request.

I was just testing the mp4 "provider" with the lastest Brighton Ruby edition, since I knew they were using their own video hosting.

@adrienpoly
Copy link
Owner

Good point, I'm more than happy to extract the video provider to its own pull request, since it's technically two "features" in one pull request.

I was just testing the mp4 "provider" with the lastest Brighton Ruby edition, since I knew they were using their own video hosting.

I will send an email to Andy. Don’t change anything for now

@h-lame
Copy link
Contributor

h-lame commented Oct 21, 2024

As someone who hosted a conference series (http://rubymanor.org) and meetup (https://lrug.org) that both used mostly self-hosted content I'm very keen to see the mp4 provider go live, but interested in what you would need from us in terms of permissions to surface it?

I think that we'd be ok with embeds if you have a nice player, but linking direct to the videos instead of embedding would also work.

@marcoroth
Copy link
Collaborator Author

marcoroth commented Oct 22, 2024

I think the whole premise of RubyVideo is to watch the talk as an embedded video on the RubyVideo site. So you get all the annotations and relevant context of where this talk took place. If you just link to the native MP4 browser player from the thumbnail on RubyVideo you loose a lot of the magic.

I'm going to extract the mp4 provider so we can use it to also embed other conferences.

@marcoroth marcoroth changed the title Implement mp4 video provider and add Brighton Ruby 2023 videos Add Brighton Ruby 2023 videos Oct 22, 2024
@marcoroth marcoroth marked this pull request as draft October 22, 2024 02:32
@marcoroth marcoroth force-pushed the brighton-ruby-2023 branch 2 times, most recently from 9dc32d3 to 271f30a Compare October 22, 2024 02:47
@marcoroth marcoroth force-pushed the brighton-ruby-2023 branch 2 times, most recently from 387fc26 to 3a0ab03 Compare October 30, 2024 22:42
@marcoroth marcoroth marked this pull request as ready for review October 30, 2024 22:45
@adrienpoly adrienpoly merged commit fa06516 into adrienpoly:main Nov 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants