No permission checks for editing/deleting records with CSV import form
Moderate severity
GitHub Reviewed
Published
Jan 23, 2024
in
silverstripe/silverstripe-admin
•
Updated Jan 29, 2024
Package
Affected versions
>= 1.0.0, < 1.13.19
>= 2.0.0, < 2.1.8
Patched versions
1.13.19
2.1.8
Description
Published by the National Vulnerability Database
Jan 23, 2024
Published to the GitHub Advisory Database
Jan 23, 2024
Reviewed
Jan 23, 2024
Last updated
Jan 29, 2024
Impact
Users who don't have edit or delete permissions for records exposed in a
ModelAdmin
can still edit or delete records using the CSV import form, provided they have create permissions.The likelyhood of a user having create permissions but not having edit or delete permissions is low, but it is possible.
Note that this doesn't affect any
ModelAdmin
which has had the import form disabled via theshowImportForm
public property, nor does it impact theSecurityAdmin
section.Action may be required
If you have a custom implementation of
BulkLoader
, you should update your implementation to respect permissions when the return value ofgetCheckPermissions()
is true.If you are using any
BulkLoader
in your own project logic, or maintain a module which uses it, you should consider passingtrue
tosetCheckPermissions()
if the data is provided by users.Base CVSS: 4.3
Reported by: Guy Sartorelli from Silverstripe
References
References