Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on-premise API bugs #11

Merged

Conversation

plamendelchev
Copy link
Contributor

The following PR fixes two bugs I encountered while using the plugin with an on-premise JIRA instance.

I have tested the changes and can confirm that the plugin works as intended with them.

@adyscorpius adyscorpius merged commit 3a27ce3 into adyscorpius:master May 20, 2024
Copy link
Owner

@adyscorpius adyscorpius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch on the apiVersion not being used on the URL.

@adyscorpius
Copy link
Owner

Hi.. I'm looking back at the original commit by @nightscape .

Is this something that is an alternative way to access on-premise API? There seems to be two types of authentication flows (Personal access tokens and Bearer auth). Is that accurate?

@plamendelchev
Copy link
Contributor Author

Hi, yes you are correct. The on-promise API can be accessed both with OAuth and Basic Authentication:
https://developer.atlassian.com/server/jira/platform/security-overview/
I personally use Basic Authentication, but I did not take into account that OAuth is also a valid option, so maybe my changes have not addressed the issue fully.

@adyscorpius
Copy link
Owner

Just went through the documentations again and funnily Basic and Bearer both work in the cloud, so there's no way of testing this stuff really.

But I've made it highly configurable now. Hopefully this new version solves for both PAT and Basic Authentication use cases. I don't think supporting OAuth makes much sense with PAT.

Happy if you all can test it out. Release v0.3.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants