Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nfc widget #920

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Improve nfc widget #920

merged 2 commits into from
Nov 15, 2024

Conversation

klmp200
Copy link
Contributor

@klmp200 klmp200 commented Nov 14, 2024

Transforme le widget nfc en un web component et ajoute une jolie animation de scan quand on l'utilise
image

@klmp200 klmp200 changed the base branch from master to taiste November 14, 2024 10:28
imperosol
imperosol reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@imperosol imperosol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pinaille.
A part ça, c'est bien.

Aussi, rebase sur taiste, pour voir si ça répare la CI d'intégrer le commit qui reset le cache de poetry dans la CI

core/static/webpack/core/components/nfc-input-index.ts Outdated Show resolved Hide resolved
@klmp200 klmp200 mentioned this pull request Nov 14, 2024
Open
@klmp200 klmp200 merged commit 9991f5d into taiste Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imperosol imperosol imperosol approved these changes

@NaNoMelo NaNoMelo Awaiting requested review from NaNoMelo

Assignees

@klmp200 klmp200

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klmp200 @imperosol