remove duplicated parameter

aeioulisa · Dec 28, 2021 · aff3dc7 · aff3dc7
1 parent f00b48d
commit aff3dc7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java b/submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java
@@ -48,7 +48,7 @@ public interface Submitter {
    * @return object
    * @throws SubmarineRuntimeException running error
    */
-  Experiment createExperiment(ExperimentSpec spec, String experimentId) throws SubmarineRuntimeException;
+  Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeException;
 
   /**
    * Find experiment by spec

diff --git a/...r/server-core/src/main/java/org/apache/submarine/server/experiment/ExperimentManager.java b/...r/server-core/src/main/java/org/apache/submarine/server/experiment/ExperimentManager.java
@@ -117,7 +117,7 @@ public Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeE
     spec.getMeta().setName(lowerName);
     spec.getMeta().setExperimentId(id.toString());
 
-    Experiment experiment = submitter.createExperiment(spec, id.toString());
+    Experiment experiment = submitter.createExperiment(spec);
     experiment.setExperimentId(id);
 
     spec.getMeta().getEnvVars().remove(RestConstants.JOB_ID);

diff --git a/...rver-core/src/test/java/org/apache/submarine/server/experiment/ExperimentManagerTest.java b/...rver-core/src/test/java/org/apache/submarine/server/experiment/ExperimentManagerTest.java
@@ -99,7 +99,7 @@ public void testCreateExperiment() {
     doReturn(experimentId).when(spyExperimentManager).generateExperimentId();
 
     // Stub mockSubmitter createExperiment
-    when(mockSubmitter.createExperiment(any(ExperimentSpec.class), any(String.class))).thenReturn(result);
+    when(mockSubmitter.createExperiment(any(ExperimentSpec.class))).thenReturn(result);
 
     // actual experiment should == expected experiment
     Experiment actualExperiment = spyExperimentManager.createExperiment(spec);

diff --git a/...r/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java b/...r/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
@@ -155,8 +155,7 @@ public void initialize(SubmarineConfiguration conf) {
   }
 
   @Override
-  public Experiment createExperiment(ExperimentSpec spec, String experimentIO) 
-        throws SubmarineRuntimeException {
+  public Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeException {
     Experiment experiment;
     try {
       MLJob mlJob = ExperimentSpecParser.parseJob(spec);

diff --git a/...tter-k8s/src/test/java/org/apache/submarine/server/submitter/k8s/K8SJobSubmitterTest.java b/...tter-k8s/src/test/java/org/apache/submarine/server/submitter/k8s/K8SJobSubmitterTest.java
@@ -98,7 +98,7 @@ public void testRunTFJobPerRequest() throws URISyntaxException, IOException, Sub
   @Test
   public void testCreateTFJob() throws IOException, URISyntaxException {
     ExperimentSpec spec = (ExperimentSpec) buildFromJsonFile(ExperimentSpec.class, tfTfboardJobReqFile);
-    Experiment experiment = submitter.createExperiment(spec, "ExperimentId-001");
+    Experiment experiment = submitter.createExperiment(spec);
   }
 
   @Test
@@ -119,7 +119,7 @@ public void testGetMlflowInfo() throws IOException, URISyntaxException {
 
   private void run(ExperimentSpec spec) throws SubmarineRuntimeException {
     // create
-    Experiment experimentCreated = submitter.createExperiment(spec, "ExperimentId-001");
+    Experiment experimentCreated = submitter.createExperiment(spec);
     Assert.assertNotNull(experimentCreated);
 
     // find