fix CesiumGS#5827

aelatgt · Sep 15, 2017 · b018f69 · b018f69
1 parent 2fa9955
commit b018f69
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 6 deletions.
diff --git a/Source/Core/Event.js b/Source/Core/Event.js
@@ -120,6 +120,10 @@ define([
         return false;
     };
 
+    function compareNumber(a,b) {
+        return b - a;
+    }
+
     /**
      * Raises the event by calling each registered listener with all supplied arguments.
      *
@@ -146,12 +150,15 @@ define([
         //Actually remove items removed in removeEventListener.
         var toRemove = this._toRemove;
         length = toRemove.length;
-        for (i = 0; i < length; i++) {
-            var index = toRemove[i];
-            listeners.splice(index, 1);
-            scopes.splice(index, 1);
+        if (length > 0) {
+            toRemove.sort(compareNumber);
+            for (i = 0; i < length; i++) {
+                var index = toRemove[i];
+                listeners.splice(index, 1);
+                scopes.splice(index, 1);
+            }
+            toRemove.length = 0;
         }
-        toRemove.length = 0;
 
         this._insideRaiseEvent = false;
     };

diff --git a/Specs/Core/EventSpec.js b/Specs/Core/EventSpec.js
@@ -45,7 +45,7 @@ defineSuite([
         expect(spyListener).not.toHaveBeenCalled();
     });
 
-    it('can remove from withing a callback', function() {
+    it('can remove from within a callback', function() {
         var doNothing = function(evt) {
         };
 
@@ -67,6 +67,27 @@ defineSuite([
         expect(event.numberOfListeners).toEqual(0);
     });
 
+    it('can remove multiple listeners within a callback', function() {
+        var listeners = [];
+
+        function addListener(index) {
+            var remove;
+            var listener = function() {
+                if (index % 2 === 0) remove(); // remove even listeners
+            };
+            remove = event.addEventListener(listener);
+            listeners.push(listener);
+        }
+
+        for (var index = 0; index < 10; index++) {
+            addListener(index);
+        }
+
+        expect(event.numberOfListeners).toEqual(10);
+        event.raiseEvent();
+        expect(event.numberOfListeners).toEqual(5);
+    });
+
     it('addEventListener and removeEventListener works with same function of different scopes', function() {
         var Scope = function() {
             this.timesCalled = 0;