Skip to content
This repository has been archived by the owner on Aug 4, 2018. It is now read-only.

Please don't merge this: Implement Winston draft #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manpages
Copy link

Hey, this is a rather dirty implementation of a winston draft.

Lacks advanced configuration options (Pool API should be refactored for that); lacks meta information; lacks deck hashing; lacks end game condition (now pool just get exhausted and all the piles will show 0 forever).

This PR, however, gives a person with more free time than myself a good overview about adding a new game type to the platform and a starting pointer about how to implement winston draft.

This PR also accidentally fixes #146.

@@ -76,6 +76,7 @@ let App = {
ws.on('message', message)
},
send(...args) {
console.log('Sending', args)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How embarrassing.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can edit the pr by pushing more commits

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I bet I won't have time. I'm in the middle of implementing a scientific paper for money, which is really too time-consuming. So that's a throw-away PR for other enthusiasts to come.

@aeosynth
Copy link
Owner

cool. can you give a prose overview?

@manpages
Copy link
Author

cool. can you give a prose overview?

I will when I have time. Most likely next weekend. :(

@aeosynth
Copy link
Owner

aeosynth commented Apr 19, 2016

alright, i got around to looking at this, and it does highlight a need for refactoring. did you only show one pile for ease of implementation, or is looking at previous piles disallowed/discouraged?

edit: ah nvm, the previous pile gets an unknown card added, so ofc you shouldn't see it

i think this has to wait for my rewrite

@manpages
Copy link
Author

Cool, I don't have any plans for doing anything with this implementation for a good while, but eventually I would like to see that finished, either through my work, or by mentoring someone else.

Sorry that I didn't post an overview, I'm way too busy these days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants