Fix "Not a valid Win32 FileTime" exception #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2024 20:53
Bump FATX to target netstandard2.1 Bump FATXTools to target .NET 8 and Windows 10 Bump System.Text.Json to 8.0.3
Fix crash when attempting to dump incorrectly parsed files
|
Would you mind updating the build pipeline please? I believe you might just need to update the .net version here: https://github.com/aerosoul94/FATXTools/blob/master/.github/workflows/build.yaml#L23 |
Update .NET actions from .NET Core 3.0 to .NET 8.0
|
Based on this GitHub support page for Actions, there is probably a better way of doing this. However, for now this should be "good enough". |
Further fixes for invalid time stamps. Although the original patch was enough to get this working in my case, it seems this is required for others
Update actions/checkout from v2 to v4 Update microsoft/setup-msbuild from v1.0.2 to v2
|
Seems that the original patch was not enough to fix this issue for all users, so here we go with round two. I've also gone ahead and updated the other pipeline dependencies to reduce the number of warnings. |
|
Looks good. Ready to be merged? |
|
Yup, all good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation for minwinbase.h, Win32 apps (and therefor Windows itself) can only handle date times as early as January 1st, 1601. However, .NET can handle date times as early as January 1st, 0001, resulting in an exception being thrown. To solve this, we now clamp the value returned by the
AsDateTimefunction.This merge also bumps the target framework from .NET Core 3.0 to .NET 8, and re-targets Windows 10, mostly for ease of installation, as .NET Core 3.0 is no longer supported.