Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various return types #1245

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Haselnussbomber
Copy link
Contributor

There are probably more wrong.
Not sure if the return type of InventoryItem.ctor is ever used, but the others are.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Component.SteamApi.SteamApi.Delegates: 1

Ctor: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Component.SteamApi.SteamApi*)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Component.SteamApi: 1

SteamApi: 1

  • void Ctor()

FFXIVClientStructs.FFXIV.Client.System.String.Utf8String.Delegates: 1

SanitizeString: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.System.String.Utf8String*, ushort, FFXIVClientStructs.FFXIV.Client.System.String.Utf8String*)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.System.String: 1

Utf8String: 1

  • void SanitizeString(ushort, FFXIVClientStructs.FFXIV.Client.System.String.Utf8String*)

FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait.Delegates: 1

Ctor: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait*)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.UI.Misc: 1

CharaViewPortrait: 2

  • FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait* Create()
  • void Ctor()

CP0008

Global: 1

  • FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait does not implement interface FFXIVClientStructs.FFXIV.Client.System.Memory.ICreatable

@github-actions github-actions bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant