-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastAPI HTTP interface #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaybeJustJames
requested review from
KrisDavie and
dweemx
and removed request for
KrisDavie and
dweemx
May 11, 2020 12:59
MaybeJustJames
force-pushed
the
286-fastapi
branch
2 times, most recently
from
May 14, 2020 09:00
2866dfc
to
64f6979
Compare
MaybeJustJames
changed the title
[WIP] Add FastAPI interface
Add FastAPI HTTP interface
May 14, 2020
This reverts commit a896897.
* main.py: Change imports * scopeserver/__init__.py: Fix typos * scopeserver/config.py: Change default app_mode to False * test/test_config.py: Test above default * package.json: Update dependency on `semantic-ui-css`
MaybeJustJames
force-pushed
the
286-fastapi
branch
from
May 15, 2020 14:47
8ab79ab
to
afba32e
Compare
KrisDavie
previously approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, works as expected and all previous functions work fine too.
Resolving merge conflict should resolve the client CI issues |
KrisDavie
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poetry run hypercorn main:scope_api --reload
Closes #286