Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastAPI HTTP interface #309

Merged
merged 17 commits into from
May 27, 2020
Merged

Add FastAPI HTTP interface #309

merged 17 commits into from
May 27, 2020

Conversation

MaybeJustJames
Copy link
Collaborator

@MaybeJustJames MaybeJustJames commented May 11, 2020

  • Adds a top-level server entrypoint. Start with poetry run hypercorn main:scope_api --reload
  • Adds hypercorn and FastAPI dependency

Closes #286

@MaybeJustJames MaybeJustJames requested review from KrisDavie and dweemx and removed request for KrisDavie and dweemx May 11, 2020 12:59
@MaybeJustJames MaybeJustJames changed the title Add FastAPI interface [WIP] Add FastAPI interface May 12, 2020
@MaybeJustJames MaybeJustJames force-pushed the 286-fastapi branch 2 times, most recently from 2866dfc to 64f6979 Compare May 14, 2020 09:00
@MaybeJustJames MaybeJustJames changed the title [WIP] Add FastAPI interface Add FastAPI HTTP interface May 14, 2020
KrisDavie
KrisDavie previously approved these changes May 27, 2020
Copy link
Contributor

@KrisDavie KrisDavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, works as expected and all previous functions work fine too.

@KrisDavie
Copy link
Contributor

Resolving merge conflict should resolve the client CI issues

Copy link
Contributor

@KrisDavie KrisDavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaybeJustJames MaybeJustJames merged commit 240f7fa into master May 27, 2020
@MaybeJustJames MaybeJustJames deleted the 286-fastapi branch May 27, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up FastAPI
2 participants