Compatibility with the next version of ACI #177
Conversation
There was a problem hiding this comment.
- please add a @deprecated notice around the line
- please add a release note that states that ACI compiler version X is deprecated
In general the old format would be dropped in next major release of the lib
src/AciTypeResolver.js
Outdated
| @@ -304,7 +304,11 @@ class AciTypeResolver { | |||
| } | |||
|
|
|||
| const def = [ | |||
| ...namespaceData.type_defs, | |||
| /** | |||
| * @deprecated ACIs generated by aesophia@7 and below | |||
There was a problem hiding this comment.
It sounds strange because I can't say what to use instead due to typedef change is not released yet
There was a problem hiding this comment.
That was my point in the previous comment, once release we can update this PR and merge it.
|
The release note is misleading that only HTTP compiler is supported, please mention that one can/should use CLI ACI (any version) |
|
@davidyuk can you tackle the comment so that we can move forward with SDK v13 ? a lot of services need to be updated and I wanna make sure this is done before the next hackathon starts |
|
The thing is that there is no new release of cli that emits new aci |
|
aesophia_cli@7.1.0 released, so I've updated the changelog |
aeternity/aesophia#421