Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1408

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Update dependencies #1408

merged 2 commits into from
Feb 11, 2022

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Feb 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1408 (70c1fac) into develop (9e8d570) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 70c1fac differs from pull request most recent head bb32b77. Consider uploading reports for the commit bb32b77 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1408      +/-   ##
===========================================
+ Coverage    87.83%   88.02%   +0.18%     
===========================================
  Files           54       54              
  Lines         3092     3090       -2     
  Branches        40       40              
===========================================
+ Hits          2716     2720       +4     
+ Misses         355      352       -3     
+ Partials        21       18       -3     
Impacted Files Coverage Δ
src/contract/ga/index.js 100.00% <ø> (ø)
src/tx/builder/helpers.js 98.75% <100.00%> (ø)
src/tx/tx-object.js 94.82% <100.00%> (+0.09%) ⬆️
src/chain/node.js 84.29% <0.00%> (+0.42%) ⬆️
src/utils/errors.ts 69.83% <0.00%> (+0.65%) ⬆️
src/utils/mptree.ts 52.00% <0.00%> (+6.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8d570...bb32b77. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 9, 2022

This pull request introduces 1 alert when merging 8ffb8ef into e54898c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

package.json Outdated
"babel-loader": "^8.2.3",
"babel-plugin-add-import-extension": "^1.6.0",
"babel-plugin-transform-default-named-imports": "^1.2.2",
"chai": "^4.3.4",
"chai": "^4.3.6",
"chai-as-promised": "^7.1.1",
"codecov": "^3.8.3",
"eslint": "^7.32.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about eslint 8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard/eslint-config-standard#209
didn't know that they have 17.0.0-1 (on next tag), switching to it

@davidyuk davidyuk merged commit 481464c into develop Feb 11, 2022
@davidyuk davidyuk deleted the feature/update-deps branch February 11, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants