Switch to aesophia with typedefs in ACI preserving current behaviour
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanssv
requested changes
Oct 31, 2022
ghallak
requested changes
Nov 1, 2022
rebar.config
Outdated
| {aesophia, {git, "https://github.com/aeternity/aesophia.git", | ||
| {tag, "v7.0.1"}}}, | ||
| {aesophia, {git, "https://github.com/davidyuk/aesophia.git", | ||
| {ref, "f4e0b56cfbf8dcd300339dd231717e2bb2e120c3"}}}, |
There was a problem hiding this comment.
Refer to this commit instead aeternity/aesophia@4ca90fe
rebar.lock
Outdated
| {git,"https://github.com/aeternity/aesophia.git", | ||
| {ref,"ad4c341a4a18c5d2920d77a2b3b36fd73f8f2147"}}, | ||
| {git,"https://github.com/davidyuk/aesophia.git", | ||
| {ref,"f4e0b56cfbf8dcd300339dd231717e2bb2e120c3"}}, |
There was a problem hiding this comment.
Just a reminder to update the lock file.
davidyuk
force-pushed
the
typedefs-in-single-word
branch
from
dc4584f
to
83e74b9
Compare
ghallak
approved these changes
Nov 21, 2022
hanssv
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to aeternity/aepp-sdk-js#1681
depends on aeternity/aesophia#421