Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] GitHub Actions #257

Closed
Ry0taK opened this issue Feb 25, 2021 · 3 comments
Closed

[Security] GitHub Actions #257

Ry0taK opened this issue Feb 25, 2021 · 3 comments

Comments

@Ry0taK
Copy link

Ry0taK commented Feb 25, 2021

Hello aevea team!
I'm a security researcher who is working on OSS security.

While doing a research related to supply chain attack, I noticed that some repositories are vulnerable to repository hijacking. (This issue has been mitigated by me and GitHub.)
Since the root cause of this issue hasn't been fixed, I'd like to let you know what you should do.

In README.md, there is an example that uses commitsar-app/release-notary to use this action.
However, as this repository has been renamed to aevea/release-notary, this example should be updated.
While it's working properly as there is a feature named Repository redirects, commitsar-app could be claimed by anyone, and allows repository hijacking once someone published new release. (I already claimed this username, so it can't be abused anymore.)
Since yay has been affected by this issue, I opened the issue on yay: Jguer/yay#1468
(For more context, I've written an article that describes this problem (It's written in Japanese): https://blog.ryotak.me/post/github-actions-supplychain/)

Best Regards,
RyotaK

@fallion
Copy link
Member

fallion commented Feb 25, 2021

@Ry0taK thanks for this find!

The README really needs updates. I will try to mitigate this today.

fallion added a commit that referenced this issue Feb 26, 2021
This causes some potential security risks. Huge thanks to @Ry0taK
Refs #257
fallion added a commit that referenced this issue Feb 26, 2021
This causes some potential security risks. Huge thanks to @Ry0taK
Refs #257
@fallion
Copy link
Member

fallion commented Feb 26, 2021

@Ry0taK this is now merged. I'll let you close it if all is ok :)

@Ry0taK
Copy link
Author

Ry0taK commented Feb 27, 2021

@fallion I've confirmed that the outdated username has been removed from README.md, thank you so much for fixing it ;)

@Ry0taK Ry0taK closed this as completed Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants