Mouse event stuck on MouseJustReleased

[trashuj]

Hello,
I noticed an issue that happens quite frequently in my app when an Interactable entity keeps receiving the MouseJustReleased event even when the mouse is at rest.
Sorry i dont have an easy repro... Though I managed to repro it in the events example, by adding more "planes" next to another, and clicking frantically on a plane then another then back etc..
Eventually you'll see the MouseJustReleased start pouring non stop, even if you take your hand off the mouse.

This seems to happen when you click on a plane then move the mouse out of the plane quickly, because it stops pourring events when you bring the cursor back on top of the stuck plane (if that makes sense)

I hope that's enought information, i'll try to find time to investigate this, might be an issue in the event system or in bevy's mouse input.

Here is the code i use to repro, in example/event.rs just replace the plane spawning by:

//plane
.spawn(PbrBundle {
mesh: meshes.add(Mesh::from(shape::Plane { size: 4.9 })),
transform: Transform::from_translation(Vec3::new(-5.0, 0.0, -5.0)),
material: materials.add(Color::rgb(1.0, 1.0, 1.0).into()),
..Default::default()
})
.with(PickableMesh::default())
.with(InteractableMesh::default())
//plane
.spawn(PbrBundle {
mesh: meshes.add(Mesh::from(shape::Plane { size: 4.9 })),
transform: Transform::from_translation(Vec3::new(0.0, 0.0, 0.0)),
material: materials.add(Color::rgb(1.0, 1.0, 1.0).into()),
..Default::default()
})
.with(PickableMesh::default())
.with(InteractableMesh::default())
//plane
.spawn(PbrBundle {
mesh: meshes.add(Mesh::from(shape::Plane { size: 4.9 })),
transform: Transform::from_translation(Vec3::new(0.0, 0.0, -5.0)),
material: materials.add(Color::rgb(1.0, 1.0, 1.0).into()),
..Default::default()
})
.with(PickableMesh::default())
.with(InteractableMesh::default())
//plane
.spawn(PbrBundle {
mesh: meshes.add(Mesh::from(shape::Plane { size: 4.9 })),
transform: Transform::from_translation(Vec3::new(-5.0, 0.0, 0.0)),
material: materials.add(Color::rgb(1.0, 1.0, 1.0).into()),
..Default::default()
})
.with(PickableMesh::default())
.with(InteractableMesh::default())

Then quickly click on 1 plane, then another, then another... etc

Hope that helps!

[trashuj]

looks like the issue is in interactable.rs.
if the interactable is not hovered anymore, the event is never reset.
Maybe we just need to reset it to None if it's not hovered.

[trashuj]

dirty fix (seems to work fine)

pub fn generate_click_events(
// Resources
mouse_inputs: Res<Input>,
// Queries
mut interactable_query: Query<(&mut InteractableMesh, &PickableMesh)>,
) {
for (mut interactable, pickable) in interactable_query.iter_mut() {
for group in &pickable.groups {
let hover = match interactable.hover(&group) {
Ok(false) => false,
Err(_) => false,
_ => true,
};
let new_event = interactable
.watched_mouse_inputs
.iter()
.map(|button| {
(
*button,
if !hover {
MouseDownEvents::None
} else if mouse_inputs.just_released(*button) {
MouseDownEvents::MouseJustReleased
} else if mouse_inputs.just_pressed(*button) {
MouseDownEvents::MouseJustPressed
} else {
MouseDownEvents::None
},
)
})
.collect();
interactable.mouse_down_events.insert(*group, new_event);
}
}
}

[trashuj]

on a side note would it be possible to send events only when the state changes?

[aevyrie]

Thanks for the example and fix, I'll take a closer look soon.

on a side note would it be possible to send events only when the state changes?

That is how it should behave in practice, are you seeing extra events somewhere?

[aevyrie]

As a follow up to the "only send events when the state changes", you can use this to only run on a state change.

bevy_mod_picking/examples/events.rs

Lines 63 to 66 in a554350

	// Only print updates if at least one event has occured.
	if hover_event.is_none() && mouse_down_event.is_none() {
	continue;
	}

PR #79 should address this issue in interactable.rs I used a slightly condensed version of the solution you provided. Thanks!

[trashuj]

Thanks, it works fine :-) Regarding events, i was thinking of an event queue so we dont need to check every entity, but I guess it's not very ECS style.

…

On Thu, Dec 17, 2020 at 7:02 AM Aevyrie ***@***.***> wrote: As a follow up to the "only send events when the state changes", you can use this to only run on a state change. https://github.com/aevyrie/bevy_mod_picking/blob/a554350d771e2c71078993ac4b3d6ad3accb180c/examples/events.rs#L63-L66 PR #79 <#79> should address this issue in interactable.rs I used a slightly condensed version of the solution you provided. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACF5UVTOZNNZTPRTQZADHTLSVGNGJANCNFSM4UAWYT7A> .

[aevyrie]

but I guess it's not very ECS style.

I'm right there with you, I'm not sure what the "best" way to do this is. I was just thinking the other day that it might make more sense to use the Bevy event system. ¯\_(ツ)_/¯