Update to Bevy 0.9 #168
Merged
Update to Bevy 0.9 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use spawn() instead of spawn_bundle() - use insert() instead of insert_bundle() - use new DefaultPlugins API
lepsalex
reviewed
Nov 13, 2022
|
Thank you! I'd prefer to keep the API the same, and include highlighting with the default plugins. The plugin group isn't needed, so I will simply add the two highlighting plugins to the default plugin builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aevyrie I prepared a small PR which updates some of the deprecated Bevy APIs. Let me know if that's ok, any feedback appreciated.
I split the
HighlightablePickingPluginsfrom being a part ofDefaultPickingPluginsI was not sure what would be a better alternative to merging two plugin groups in the PluginGroup::build trait implementation. Is that ok or do you have a suggestion on what to do there?