Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level from info to debug and trace #262

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

mattdm
Copy link
Contributor

@mattdm mattdm commented Sep 30, 2023

This implements #259.

Messages linked to the "Noisy" debug state are logged with trace!(). The rest are logged with debug!(). Filtering on this could replace the Noisy/Normal state distinction entirely (perhaps leaving the DebugPickingMode state only for hiding or showing the cursor text overlay) but I'll leave that possibility for the future. This just makes a minimal change.

mattdm and others added 3 commits September 30, 2023 15:41
This implements aevyrie#259.

Messages linked to the "Noisy" debug state are logged with `trace!()`.
The rest are logged with `debug!()`. Filtering on this _could_ replace
the Noisy/Normal state distinction entirely (perhaps leaving the
DebugPickingMode state _only_ for hiding or showing the cursor text
overlay) but I'll leave that possibility for the future. This just
makes a minimal change.
Copy link
Owner

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much needed improvement. Thanks!

@aevyrie aevyrie merged commit 35fbbf8 into aevyrie:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants