Update to Bevy v0.11 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deriving Reflect - change type bound to `TypePath` Migrate to new `add_systems`
Use `camera.viewport_to_world()`
Migrate to new `add` apis Revert tonemapping to ReinhardLuminance to avoid the `tonemapping_luts` feature
|
Using reinhard luminance is a good solution to the tonemap situation, I mentioned my own work on bevy 0.11 there, if a comparison is useful feel free to mix and match #78 (comment) (coreh#1) |
|
🎉 Thanks for picking this up, last couple of weeks were packed and I didn't have the bandwidth to keep the other PR up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #78
Changes
add_systemsAPIReflectinstead of usingimpl_reflect(_from)_valueReflecttype argument bound withTypePath(https://bevyengine.org/learn/migration-guides/0.10-0.11/#bevy-reflect-stable-type-path-v2)camera.view_to_world()to implementRay3d::from_screenspace(previous work: Ray3d::from_screenspace orthographic improvements #83 Ray3d::from_screenspace() implementation from Camera.viewport_to_world() #76) (see Consistent screen-space coordinates bevyengine/bevy#8306)ReinhardLuminancetone mapping in examples (default tone mapping now requires including LUTs)