Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AYS-29 | Pagination Infrastructure Has Been Refactored and Pagination Validations Have Been Fixed #271

Merged
merged 3 commits into from
Dec 28, 2023
Merged

AYS-29 | Pagination Infrastructure Has Been Refactored and Pagination Validations Have Been Fixed #271

merged 3 commits into from
Dec 28, 2023

Conversation

agitrubard
Copy link
Collaborator

Description

  • Pagination Infrastructure Has Been Refactored and Pagination Validations Have Been Fixed
  • @Valid Annotation Has Been Added to Parameter of AdminUserRegisterApplicationController.getRegistrationApplications() Method
  • @UUID Annotation Has Been Added to Parameter of AdminUserRegisterApplicationController.getRegistrationApplicationById() Method

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@agitrubard agitrubard linked an issue Dec 17, 2023 that may be closed by this pull request
Pagination Kullanılan Endpointlerdeki Page Değerinin Sınırlarının Belirlenmesi #221
Closed
@agitrubard agitrubard changed the title #221 | Pagination Infrastructure Has Been Refactored and Pagination Validations Have Been Fixed AYS-29 | Pagination Infrastructure Has Been Refactored and Pagination Validations Have Been Fixed Dec 20, 2023
@agitrubard agitrubard merged commit ba81d24 into main Dec 28, 2023
1 check passed
@agitrubard agitrubard deleted the bugfix/221/pagination branch December 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhatkayikci serhatkayikci serhatkayikci approved these changes

@AhmetAksunger AhmetAksunger AhmetAksunger approved these changes

@emreylmaz emreylmaz Awaiting requested review from emreylmaz

@ibrahimdenizz ibrahimdenizz Awaiting requested review from ibrahimdenizz

@moaydogdu moaydogdu Awaiting requested review from moaydogdu

@anilhazar anilhazar Awaiting requested review from anilhazar

@skayikci skayikci Awaiting requested review from skayikci skayikci is a code owner

@Rapter1990 Rapter1990 Awaiting requested review from Rapter1990

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination Kullanılan Endpointlerdeki Page Değerinin Sınırlarının Belirlenmesi
4 participants
@agitrubard @Rapter1990 @AhmetAksunger @serhatkayikci