Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#79 is breaking travis on python-2.7 #154

Closed
GuillaumeSeren opened this issue Aug 1, 2017 · 5 comments
Closed

#79 is breaking travis on python-2.7 #154

GuillaumeSeren opened this issue Aug 1, 2017 · 5 comments

Comments

@GuillaumeSeren
Copy link
Collaborator

GuillaumeSeren commented Aug 1, 2017

After merging the #145 I noticed that travis is complaining on python-2.7,
as this build fine on other python (3.4, 3.5, 3.6) https://travis-ci.org/afewmail/afew/builds/259724537?utm_source=github_status&utm_medium=notification

======================================================================

ERROR: test_multi_line_config (afew.tests.test_multi_line_config.TestMultiLineConfig)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/afewmail/afew/afew/tests/test_multi_line_config.py", line 25, in setUp

    settings.clear ()

AttributeError: 'SafeConfigParser' object has no attribute 'clear'

----------------------------------------------------------------------

Ran 5 tests in 0.169s

FAILED (errors=1)

Test failed: <unittest.runner.TextTestResult run=5 errors=1 failures=0>

error: Test failed: <unittest.runner.TextTestResult run=5 errors=1 failures=0>

The command "coverage run --source=afew setup.py test" exited with 1.
@GuillaumeSeren
Copy link
Collaborator Author

According to https://docs.python.org/3/library/configparser.html,
the function .clear() was added in python-3.2, explaining the problem.

@flokli What do you think ?

@flokli
Copy link
Member

flokli commented Aug 1, 2017

.clear() usage was introduced in #79, not #154, for which no travis build was triggered, as travis wasn't used in 2014. I reverted this PR for now (see #155), which should fix the build on master again, and we can rework the patch in #79

@GuillaumeSeren
Copy link
Collaborator Author

@flokli ok fine to me !

@GuillaumeSeren
Copy link
Collaborator Author

Despite this tiny itch in the tests (only for 2.7 tho), we have fast-forward all pending/merge-able request,
and we should be able to concentrate more effort on current (than old) ones.

@flokli flokli changed the title #145 is breaking travis on python-2.7 #79 is breaking travis on python-2.7 Aug 1, 2017
@flokli
Copy link
Member

flokli commented Mar 8, 2019

Python 2.7 was dropped from travis since quite some time, and we don't run on 2.7 anymore, so this can be closed.

@flokli flokli closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants