MailMover: Only run 'notmuch new' if any mails were actually moved #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `afew --move`, the notmuch database is always updated, even if not files were actually moved. Since this takes a non-trivial amount of time, the time to run afew can actually be dominated by the database update, which is annoying when putting afew into an automated 'check new mails' hook. This adds a small optimisation where the database is only updated if any messages were actually moved. This makes running `afew --move` substantially faster in the common case were no messages need to be moved. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
|
Hey @tohojo thank for sharing this patch, I let other maintainer have a look but I think this could be merged. |
GuillaumeSeren
approved these changes
Jul 13, 2017
|
@flokli Can you have a look ? |
flokli
approved these changes
Jul 16, 2017
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
afew --move, the notmuch database is always updated, even if notfiles were actually moved. Since this takes a non-trivial amount of time, the
time to run afew can actually be dominated by the database update, which is
annoying when putting afew into an automated 'check new mails' hook.
This adds a small optimisation where the database is only updated if any
messages were actually moved. This makes running
afew --movesubstantiallyfaster in the common case were no messages need to be moved.
I realise this pull requests conflicts with some of the other open pull requests
that also touch MailMover; but since this one is fairly small, it should be
simple to incorporate in those as well :)