Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: don't require notmuch when building inside readthedocs #192

Merged
merged 1 commit into from
Apr 11, 2018
Merged

setup.py: don't require notmuch when building inside readthedocs #192

merged 1 commit into from
Apr 11, 2018

Conversation

flokli
Copy link
Member

@flokli flokli commented Apr 11, 2018

No description provided.

@flokli flokli requested a review from GuillaumeSeren April 11, 2018 13:18
@flokli
Copy link
Member Author

flokli commented Apr 11, 2018

Doc builds are currently broken, as readthedocs can't find notmuch python bindings.

Build at http://afew.readthedocs.io/en/readthedocs/ (this branch) went through

GuillaumeSeren
GuillaumeSeren approved these changes Apr 11, 2018
View reviewed changes
Copy link
Collaborator

@GuillaumeSeren GuillaumeSeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuillaumeSeren GuillaumeSeren merged commit 6ac0d91 into master Apr 11, 2018
@flokli flokli deleted the readthedocs branch April 11, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeSeren GuillaumeSeren GuillaumeSeren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flokli @GuillaumeSeren