Use db.find_message
in Filter.commit
#203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
notmuch.Database.find_message
instead ofnotmuch.Query
as a more idiomatic way to get a message and to avoid problems with escaping double quotes.A little background... I tried using
afew
a few months back, but ran into crashing bugs withInboxFilter
, I've spent some time this morning trying to get to the bottom of them.Basically some of my messages have
id
tags with a"
in them. I tried escaping the double quote, but there isn't that much info on it, I think you're supposed to repeat them (e.g."
becomes""
). However usingDatabase.find_message
is a better solution, and may even have better performance.