Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use db.find_message in Filter.commit #203

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Conversation

samdoshi
Copy link
Contributor

Use notmuch.Database.find_message instead of notmuch.Query as a more idiomatic way to get a message and to avoid problems with escaping double quotes.


A little background... I tried using afew a few months back, but ran into crashing bugs with InboxFilter, I've spent some time this morning trying to get to the bottom of them.

Basically some of my messages have id tags with a " in them. I tried escaping the double quote, but there isn't that much info on it, I think you're supposed to repeat them (e.g. " becomes ""). However using Database.find_message is a better solution, and may even have better performance.

use `notmuch.Database.find_message` instead of `notmuch.Query` as a more
idiomatic way to get a message and to avoid problems with escaping double quotes
@flokli flokli merged commit 9f9d999 into afewmail:master Jul 21, 2018
@flokli
Copy link
Member

flokli commented Jul 21, 2018

Thanks!

@samdoshi
Copy link
Contributor Author

Thanks for the quick response!

Any idea (roughly) when the next release might be tagged?

@flokli
Copy link
Member

flokli commented Jul 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants