Drop Python 2 support from docs, remove Python 2 hacks #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @flokli But IMO it is ok to do it, but we will need to tag a major version to reflect the change (v2). |
flokli
force-pushed
the
nuke-py2
branch
2 times, most recently
from
33c2095 to
183db1c
Compare
|
Travis doesn't seem to support python 3.7 (yet), would have added that too :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already encourage running afew with Python 3 for some time now, and there's some weird bugs when running with Python 2 (#180, #181).
Given Python 3 is available almost everywhere too, let's get rid of python 2 and hacks present in the codebase.
cc @varac