Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop Python 3.4 and 3.5 #245

Merged
merged 1 commit into from
Sep 24, 2019
Merged

drop Python 3.4 and 3.5 #245

merged 1 commit into from
Sep 24, 2019

Conversation

flokli
Copy link
Member

@flokli flokli commented Sep 23, 2019

This allows to use some more recent Python features, and even Debian stable comes with 3.7 by now.

@flokli flokli mentioned this pull request Sep 23, 2019
Merged
@GuillaumeSeren
Copy link
Collaborator

We are becoming elitist 🐍

@GuillaumeSeren GuillaumeSeren merged commit 289a9bf into afewmail:master Sep 24, 2019
@kyrias
Copy link
Contributor

kyrias commented Sep 24, 2019 •
edited
Loading

Looks like the tests are only built on 3.7 now: https://travis-ci.org/afewmail/afew/builds/589083000

I think there needs to be a

- python: 3.6
  dist: xenial

in the matrix.include sections to run both?

@flokli
Copy link
Member Author

flokli commented Sep 25, 2019

@kyrias thanks for catching that! I opened #246 to fix that.

@flokli flokli deleted the drop-py34,35 branch September 25, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeSeren GuillaumeSeren GuillaumeSeren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flokli @GuillaumeSeren @kyrias