Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-3.8 compatibility #255

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

jedbrown
Copy link
Contributor

Upon upgrading to python-3.8, I encountered these two issues, which are resolved in this PR.

TypeError: object of type 'filter' has no len()
/home/jed/src/afew/afew/filters/__init__.py:9: SyntaxWarning: "is not" with a literal. Did you mean "!="?                                                                                      
  if filename is not '__init__.py')         

@tohojo
Copy link
Contributor

tohojo commented Nov 15, 2019

Heh, guess I should have looked for this first. Please ignore #256 then :)

Copy link
Contributor

@tohojo tohojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@tohojo tohojo mentioned this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants