Migrate to Bootstrap 5.0.0.alpha3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbuccini
force-pushed
the
bootstrap5.0.0.alpha3
branch
from
95ec387
to
4d4db84
Compare
stevenbuccini
force-pushed
the
bootstrap5.0.0.alpha3
branch
from
4d4db84
to
19b3ee3
Compare
|
hey @stevenbuccini thanks for this PR. I've rebased this onto a Bootstrap 5 branch for now until it's released. (I want to keep BS4's branch as BS4) When BS5 is out officially, I would be okay making the main/master branch BS5. Does that sound good to you? |
|
I think that's a great plan! I simply used that as the base branch to reduce the noise in the PR. Thanks for the quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.form-labelclass. Docs say:.form-group. This method has been removed in Bootstrap 5. The maintainers replaced it in their docs with.mb-3and I have done the same.