Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReasoningAgent #115

Merged
merged 16 commits into from
Dec 5, 2024
Merged

ReasoningAgent #115

merged 16 commits into from
Dec 5, 2024

Conversation

Hk669
Copy link
Collaborator

@Hk669 Hk669 commented Nov 30, 2024

Why are these changes needed?

  • basic working implementation of the ReasoningAgent
  • Notebook on how to use the ReasoningAgent
  • Nested Chats
  • Doc strings and comments
  • Tests
  • Blog Post

Related issue number

Closes #114

Checks

@Hk669
Copy link
Collaborator Author

Hk669 commented Dec 4, 2024

Ideas for more modular implementation: Break down the search process into a swarm chat:

  • ExpandAndGradeAgent uses (async) nested sequential chats:

    • In n_leaf async chats, use the ThinkAgent to expand the current leaf nodes and the GradeAgent to score each;
  • SelectionAgent: use a custom reply function to select top nodes to keep; the AFTER_WORK transition is to ExpandAndGradeAgent or terminate, depending on whether the search has finished.

we can have this implemented in the new PR, once this is merged. Thanks!

@qingyun-wu
Copy link
Collaborator

@Hk669 could you fix the doc format issue? Thank you! Otherwise, I think it is close to being merged!

@qingyun-wu
Copy link
Collaborator

Ideas for more modular implementation: Break down the search process into a swarm chat:

  • ExpandAndGradeAgent uses (async) nested sequential chats:

    • In n_leaf async chats, use the ThinkAgent to expand the current leaf nodes and the GradeAgent to score each;
  • SelectionAgent: use a custom reply function to select top nodes to keep; the AFTER_WORK transition is to ExpandAndGradeAgent or terminate, depending on whether the search has finished.

we can have this implemented in the new PR, once this is merged. Thanks!

@Hk669 sounds great! Could you open an issue in case we forget later? Thank you!

@Hk669
Copy link
Collaborator Author

Hk669 commented Dec 5, 2024

Ideas for more modular implementation: Break down the search process into a swarm chat:

  • ExpandAndGradeAgent uses (async) nested sequential chats:

    • In n_leaf async chats, use the ThinkAgent to expand the current leaf nodes and the GradeAgent to score each;
  • SelectionAgent: use a custom reply function to select top nodes to keep; the AFTER_WORK transition is to ExpandAndGradeAgent or terminate, depending on whether the search has finished.

we can have this implemented in the new PR, once this is merged. Thanks!

@Hk669 sounds great! Could you open an issue in case we forget later? Thank you!

Sure let me do it. Thanks!

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Hk669 and @BabyCNM!

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit a366da3 Dec 5, 2024
206 of 214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: ReasoningAgent
4 participants