Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: llamaindex_conversable_agent.py #130

Merged
merged 6 commits into from
Dec 15, 2024
Merged

update: llamaindex_conversable_agent.py #130

merged 6 commits into from
Dec 15, 2024

Conversation

lazToum
Copy link
Collaborator

@lazToum lazToum commented Dec 2, 2024

Why are these changes needed?

If using pydantic > 2, we get AttributeError: type object 'Config' has no attribute 'copy'
A simple check is added to avoid this.

Related issue number

Checks

@marklysze
Copy link
Collaborator

Hey @lazToum! Thanks for putting these PRs through. Are you on Discord? If so can you connect to me, msze_, so we can send out a CLA for you?

@lazToum
Copy link
Collaborator Author

lazToum commented Dec 2, 2024

Hey @lazToum! Thanks for putting these PRs through. Are you on Discord? If so can you connect to me, msze_, so we can send out a CLA for you?

Hi @marklysze, sure, it's laztoum at discord. I have already signed one that Qingyun Wu sent me.

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @lazToum thanks for your contribution!

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 15, 2024
Merged via the queue into main with commit 5e7758b Dec 15, 2024
206 of 214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants