Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/logging #132

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Patch/logging #132

merged 3 commits into from
Dec 3, 2024

Conversation

lazToum
Copy link
Collaborator

@lazToum lazToum commented Dec 2, 2024

Why are these changes needed?

Related issue number

Checks

@marklysze
Copy link
Collaborator

Thanks @lazToum...

@Hk669 are you able to assist in testing this?

@marklysze marklysze requested a review from Hk669 December 3, 2024 01:06
@Hk669
Copy link
Collaborator

Hk669 commented Dec 3, 2024

Yes, let me test it on windows.

Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks @lazToum

@Hk669 Hk669 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 95431af Dec 3, 2024
206 of 214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants