-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context variables to ConversableAgent #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sze <mark@sze.family>
marklysze
changed the title
Add context_variables to ConversableAgent
Add context variables to ConversableAgent
Dec 2, 2024
Merged
3 tasks
Signed-off-by: Mark Sze <mark@sze.family>
Signed-off-by: Mark Sze <mark@sze.family>
sonichi
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one optional suggestion.
sonichi
reviewed
Dec 4, 2024
Signed-off-by: Mark Sze <mark@sze.family>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As a means to support the current SwarmAgent implementation and provide future agent-level context variables, we add context variables to a ConversableAgent. Each agent has their own independent context variables.
This will be a dictionary, Dict[str, Any] and interacting with it should be done through getter/setter functions:
E.g.
Note: If context variables are passed in when establishing a ConversableAgent it must be able to be deep-copied.
docstring for ConversableAgent has been updated - no other specific documentation has been added. Let me know if it needs it at this stage.
Related issue number
PR #104 is a dependency on this.
Checks