Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Function Execution return a non-string object #25

Merged
merged 10 commits into from
Nov 20, 2024
Merged

Allow Function Execution return a non-string object #25

merged 10 commits into from
Nov 20, 2024

Conversation

yiranwu0
Copy link
Collaborator

Why are these changes needed?

When a function call being executed, we want to return the original object. Any non-str objects will be cast to str before being appended to messages to avoid any error.

Minor: Fix print: tool calls will return the name twice.

Related issue number

Checks

@sonichi
Copy link
Collaborator

sonichi commented Nov 16, 2024

Many tests fail in the CI.

@sonichi sonichi requested a review from marklysze November 16, 2024 23:33
@qingyun-wu
Copy link
Collaborator

@yiranwu0 could you update this PR once #47 is merged?

@yiranwu0
Copy link
Collaborator Author

@yiranwu0 could you update this PR once #47 is merged?

Sure!

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Yiran!

@qingyun-wu qingyun-wu merged commit f74c3ed into main Nov 20, 2024
163 of 164 checks passed
davorrunje pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants