Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.6.1 #325

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Bump version to 0.6.1 #325

merged 6 commits into from
Dec 30, 2024

Conversation

marklysze
Copy link
Collaborator

@marklysze marklysze commented Dec 30, 2024

Why are these changes needed?

Bump version to 0.6.1 for release.

Includes an update for the websocket test file to handle closed connections.

Related issue number

N/A

Checks

@marklysze
Copy link
Collaborator Author

OpenAI tests have passed previously in this PR, fixed a pre-commit formatting issue. we're good to go with this version if you could review and approve.

@sonichi sonichi requested a review from davorrunje December 30, 2024 22:28
Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a question, though it's not introduced by this PR.

message = message.decode("utf-8") if isinstance(message, bytes) else message
# drop the newline character
if message.endswith("\n"):
message = message[:-1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the log harder to read. What's the benefit?

@marklysze marklysze merged commit 417672f into main Dec 30, 2024
211 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants